G1j mx uxe/4182 inapp mock change to open new tab#57
Merged
Conversation
…ion in a new tab. Updated Inbox, Notification, NotificationFeed, NotificationLauncher, and NotificationPopup components accordingly.
GreyNewfie
approved these changes
Nov 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Added an optional newTab boolean prop to control whether notification links open in a new tab or the same window. When newTab is true, clicking a notification uses window.open(redirectURL, '_blank'); otherwise (default), it uses window.location.href (same window). The prop is available on NotificationFeed, NotificationPopup, and NotificationLauncher and is passed through to the underlying Notification component. This preserves existing behavior when not provided, so existing implementations are unaffected.
I will git the docs and dashboard updated here now in a pr as well.
Trello Task:
https://trello.com/c/G1jMxUxe/4182-inapp-mock-change-to-open-new-tab